Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: canvas.activeTracker add targer prop #2044

Merged
merged 1 commit into from May 17, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner May 17, 2023 10:58
@github-actions
Copy link

ChatGPT Code Review:

  1. 代码审查建议:
  • 代码变更建议增加详细的描述信息
  • 变更需要标注原因和后续影响
  • 建议在代码中加入注释,解释代码的作用和过程,增加代码可读性。
  1. 代码功能描述:
    该代码变更修改了 canvas.activeTracker 添加了 _target 属性,并在 TreeMaster 类的 initEvent() 方法中增加了 setExpandByActiveTracker() 函数用于设置 target 的展开状态以及滚动到相应的节点位置。其中 canvas.activeTracker 是一个激活状态追踪器,用于追踪当前处于激活状态的对象,_targetActiveTracker 类的一个私有属性,用于追踪激活状态的目标节点。 TreeMaster 类是插件 plugin-outline-pane 的一个控制类,用于控制树形节点的展开和收缩以及节点的滚动等。 setExpandByActiveTracker() 函数被调用的时候,会判断 tree 是否有值,如果有则代表当前有树形结构,会根据 detail 判断是否展开其子节点,还是展开其上层节点,并通过 board 进行滚动显示。

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 9077443

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9077443

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 9077443

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.06% 1628/1828
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 9077443

@JackLian JackLian merged commit 2b3d96c into develop May 17, 2023
18 checks passed
@JackLian JackLian deleted the feat/active-tracker-target branch May 17, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants