Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workspace window add onSave api #2055

Merged
merged 1 commit into from May 23, 2023
Merged

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner May 19, 2023 09:20
@github-actions
Copy link

ChatGPT Code Review:

  1. 代码本身没有错误,没有拼写错误,无需做出修改建议。
  2. 代码主要是关于窗口和视图的操作。新增了一个 onSave 方法,用于注册窗口视图保存事件。可以通过此方法,当窗口视图要保存时进行一些操作。该方法定义在 IPublicModelWindowWindow 接口中。同时在 EditorWindow 实现中也有对应的实现。此外,还修复了 OutlinePaneContext 组件中 treeMaster.onPluginContextChange 监听的使用问题。

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 4a5fd47

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 4a5fd47

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.06% 1628/1828
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 4a5fd47

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 4a5fd47

@JackLian JackLian merged commit b984ef7 into develop May 23, 2023
19 checks passed
@JackLian JackLian deleted the feat/workspace-window-onSave branch May 23, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants