Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils|types): add esmodule support for component meta resources #2603

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

keuby
Copy link
Contributor

@keuby keuby commented Nov 1, 2023

AssetJson 支持的 components 支持 esmodule 的脚本。例如:

{
    "version": "0.0.1",
    "packages": [
        // ...
    ],
    "components": [
        {
            "url": {
                "type": "jsUrl",
                "content": "http://localhost:3000/meta.js",
                "scriptType": "module"
            },
            "exportName": "MyCompoentMeta",
            "package": {
                "npm": "my-component"
            }
        }
    ]
}

@liujuping
Copy link
Collaborator

描述一下变更的背景。

@keuby keuby changed the title feat(utils): support script type param for assest loader feat(utils|types): add esmodule support for component meta resources Nov 4, 2023
@keuby
Copy link
Contributor Author

keuby commented Nov 4, 2023

变更背景已更新。

我添加了 IPublicTypeAssetsJson 中 components 里面 IPublicTypeRemoteComponentDescription 里 url 的描述,这里可以支持更复杂的资源配置

@liujuping liujuping merged commit e3611dc into alibaba:develop Nov 7, 2023
12 checks passed
@JackLian
Copy link
Collaborator

JackLian commented Nov 7, 2023

1.2.2-beta.3

@keuby
Copy link
Contributor Author

keuby commented Nov 9, 2023

@JackLian 1.2.2-beta.3 当前这个功能不能正常 work,在构建 @alilc/lowcode-engine 这个包的 umd 产物的时候,使用的 @alilc/lowcode-utils 是老版本的,不是更新后的。

JackLian pushed a commit that referenced this pull request Nov 10, 2023
…2603)

* feat(utils): support script type param for assest loader

* feat(types): update AssestsJson type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants