Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support register persistent instance by GRPC request #11393

Closed
KomachiSion opened this issue Nov 17, 2023 · 1 comment · Fixed by #11430
Closed

Support register persistent instance by GRPC request #11393

KomachiSion opened this issue Nov 17, 2023 · 1 comment · Fixed by #11430
Assignees
Labels
kind/feature type/feature
Milestone

Comments

@KomachiSion
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

After #8789 merged into 2.3.0. Nacos client can get server abilities supported.
So I can let client to judge whether can do register persistent instance by http(old way) or grpc(new way).

Describe the solution you'd like

  1. Add PersistentInstanceRequest in 2.3.0 server and client.
  2. Add ability tag like supportPersistentInstanceByGrpc in AbilityTables of 2.3.0 server and client.
  3. when using 2.3.0 client and later version, it can judge whether use grpc request to register persistent instance, if server supported, use grpc request, otherwise use old way to adapt it.
@KomachiSion KomachiSion added the kind/feature type/feature label Nov 17, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Nov 17, 2023
@Bo-Qiu
Copy link
Contributor

Bo-Qiu commented Nov 21, 2023

I'll solve it, please assign to me, thx!

Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 24, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 25, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Nov 27, 2023
KomachiSion pushed a commit that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants