Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.alibaba.nacos.naming.misc.HttpClient#httpPutLarge is a little odd #2237

Closed
rushsky518 opened this issue Dec 29, 2019 · 2 comments · Fixed by #2287
Closed

com.alibaba.nacos.naming.misc.HttpClient#httpPutLarge is a little odd #2237

rushsky518 opened this issue Dec 29, 2019 · 2 comments · Fixed by #2287
Assignees
@rushsky518
Labels
kind/refactor
Milestone
1.3.1

Comments

@rushsky518
Copy link
Contributor

rushsky518 commented Dec 29, 2019 •
edited

image

image

byte[] content -> String
then
String -> byte[]

i suggest ByteArrayEntity. Can i change it?
@nkorange
Copy link
Collaborator

nkorange commented Jan 3, 2020

Welcome to contribute!

@rushsky518
Copy link
Contributor Author

@i will solve it@

rushsky518 added a commit to rushsky518/nacos that referenced this issue Jan 10, 2020
@rushsky518
alibaba#2237 1. use ByteArrayEntity 2. getDeclaredMethods
0d304c0
rushsky518 added a commit to rushsky518/nacos that referenced this issue Jan 15, 2020
@rushsky518
alibaba#2237 directly use byte[]
b1ffbad
rushsky518 added a commit to rushsky518/nacos that referenced this issue Jan 24, 2020
@rushsky518
alibaba#2237 add a IT_test
8fe3eba
@rushsky518 rushsky518 mentioned this issue Jun 10, 2020
Merged
@KomachiSion KomachiSion linked a pull request Jun 10, 2020 that will close this issue
HttpCLient uses ByteArrayEntity when sync data #2287
Merged
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushsky518 rushsky518

Labels
kind/refactor
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

HttpCLient uses ByteArrayEntity when sync data rushsky518/nacos
3 participants
@nkorange @rushsky518 @KomachiSion