Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's no use setting the default property "minIdle" of HikariPool by nacos #3300

Closed
CsyDesign opened this issue Jul 11, 2020 · 0 comments
Closed

It's no use setting the default property "minIdle" of HikariPool by nacos #3300

CsyDesign opened this issue Jul 11, 2020 · 0 comments
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
1.3.2

Comments

@CsyDesign
Copy link
Contributor

It's no use setting the default property "minIdle" of HikariPool by nacos

Nacos设置的Hikari连接池默认最小空闲数没起效

nacos version = 1.3.1
"DEFAULT_MAX_POOL_SIZE" should be greater than or equal to "DEFAULT_MINIMUM_IDLE"
"DEFAULT_MAX_POOL_SIZE" 应该大于等于 "DEFAULT_MINIMUM_IDLE"

image

image

current 目前

nacos version = 1.3.1
DEFAULT_MAX_POOL_SIZE < DEFAULT_MINIMUM_IDLE

expected 期望

DEFAULT_MAX_POOL_SIZE >= DEFAULT_MINIMUM_IDLE

suggestions 建议

DEFAULT_MAX_POOL_SIZE = DEFAULT_MINIMUM_IDLE
reason：When they are equal, the connection pool will not suddenly fluctuate.
理由：当他们相等时，连接池不会突然波动。
CsyDesign pushed a commit to CsyDesign/nacos that referenced this issue Jul 11, 2020
@drcsy
For alibaba#3300, optimize the default HikariPool property at Externa…
0efedf5 
…lDataSourceProperties.DEFAULT_MINIMUM_IDLE
CsyDesign pushed a commit to CsyDesign/nacos that referenced this issue Jul 11, 2020
@drcsy
For alibaba#3300, 优化Naocs默认设置的Hikari连接池最小空闲数
3a3acaf
@CsyDesign CsyDesign mentioned this issue Jul 11, 2020
Merged
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jul 13, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 13, 2020
@KomachiSion KomachiSion mentioned this issue Aug 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
3 participants
@chuntaojun @KomachiSion @CsyDesign