Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 Service list Cannot query by group name #4282

Closed
zhujiebing opened this issue Nov 20, 2020 · 2 comments · Fixed by #4308
Closed

1.4.0 Service list Cannot query by group name #4282

zhujiebing opened this issue Nov 20, 2020 · 2 comments · Fixed by #4308
Assignees
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.

Comments

@zhujiebing
Copy link

zhujiebing commented Nov 20, 2020

Describe the bug
image
image

@binbin0325 binbin0325 added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Nov 20, 2020
@mark4z
Copy link
Contributor

mark4z commented Nov 21, 2020

@i will fix it.

@mark4z
Copy link
Contributor

mark4z commented Nov 21, 2020

The interface return 'Param 'serviceName' is illegal, serviceName is blank', it should be optional in this one.

issue #3687 add a strong verification when NamingUtils.getGroupedName().

So, I think add a function without verification would be better.

    public static String getGroupedName(final String serviceName, final String groupName) {
        if (StringUtils.isBlank(serviceName)) {
            throw new IllegalArgumentException("Param 'serviceName' is illegal, serviceName is blank");
        }
        final String resultGroupedName = groupName + Constants.SERVICE_INFO_SPLITER + serviceName;
        return resultGroupedName.intern();
    }

@binbin0325 binbin0325 assigned binbin0325 and mark4z and unassigned binbin0325 Nov 21, 2020
@zhujiebing zhujiebing changed the title 1.4.0 Service list Cannot query by service name 1.4.0 Service list Cannot query by group name Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
3 participants