Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.1] Services deleted when upgrading to v2 will not be sync to v2 model. #5692

Closed
pixystone opened this issue May 13, 2021 · 0 comments
Closed

[2.0.1] Services deleted when upgrading to v2 will not be sync to v2 model. #5692

pixystone opened this issue May 13, 2021 · 0 comments
Labels
kind/bug Category issues or prs related to bug. version/2.x
Milestone
2.0.2

Comments

@pixystone
Copy link
Contributor

Describe the bug

Services deleted by ServiceController.remove, but still in v2.ServiceManager with instances.

Expected behavior

com.alibaba.nacos.naming.core.Service#destroy need some notification.

.e.g.

        ApplicationUtils.getBean(DoubleWriteEventListener.class)
                .doubleWriteMetadataToV2(this, vDom.isEphemeral());

Like com.alibaba.nacos.naming.core.Service#update dose.

Additional context

Need to do some check for services in com.alibaba.nacos.naming.core.v2.upgrade.doublewrite.execute.AsyncServicesCheckTask.
pixystone added a commit to pixystone/nacos that referenced this issue May 13, 2021
@pixystone
[ISSUE alibaba#5692] Add double write task sensing removal of v2 serv…
01676ac 
…ice.
pixystone added a commit to pixystone/nacos that referenced this issue May 13, 2021
@pixystone
[ISSUE alibaba#5692] Add double write task sensing removal of v1 serv…
99831ac 
…ice.
pixystone added a commit to pixystone/nacos that referenced this issue May 13, 2021
@pixystone
[ISSUE alibaba#5692] Make async checker of services sensing removal o…
3ee6d78 
…f v1 service.
@pixystone pixystone mentioned this issue May 13, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue May 14, 2021
@pixystone
[ISSUE #5692] Make service removal sensed by double write. (#5706)
98aae39 
* [ISSUE #5692] Add double write task sensing removal of v2 service.

* [ISSUE #5692] Add double write task sensing removal of v1 service.

* [ISSUE #5692] Make async checker of services sensing removal of v1 service.
@KomachiSion KomachiSion added version/2.x kind/bug Category issues or prs related to bug. labels May 14, 2021
@KomachiSion KomachiSion added this to the 2.0.2 milestone May 14, 2021
@pixystone pixystone mentioned this issue May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug. version/2.x
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
2 participants
@pixystone @KomachiSion