Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ResourceParser groupName change the splicing method. #5888

Closed
CherishCai opened this issue May 28, 2021 · 5 comments
Closed

Feature: ResourceParser groupName change the splicing method. #5888

CherishCai opened this issue May 28, 2021 · 5 comments
Assignees
@TsingLiang
Labels
kind/refactor
Milestone
2.0.2

Comments

@CherishCai
Copy link
Contributor

不知道为什么 groupName 的拼接 依赖 dataId 的判空，我基于权限的增强来看，可以基于 group 来作整个分组的权限授予，
我已变更其拼接方式，作验证中，现提交一个 pr，若有其他原因的考虑请拒绝。
CherishCai added a commit to CherishCai/nacos that referenced this issue May 28, 2021
@CherishCai
feat(alibaba#5888): ResourceParser groupName change the splicing method.
df147db
@CherishCai CherishCai mentioned this issue May 28, 2021
Merged
@KomachiSion
Copy link
Collaborator

@TsingLiang Can you answer this question?

@TsingLiang
Copy link
Collaborator

因为接口参数定义都是内部做的，dataId存在的时候group应该也存在，改之后严谨一点，可以改改优化一下

@CherishCai
Copy link
Contributor Author

在控制台查询的时候，是可以仅传参 groupName 无 dataId 的，所以如果 groupName 不依赖 dataId 可以做到 group 分组授权。

@KomachiSion
Copy link
Collaborator

能在PR中添加一下UT吗？ 以保证除了你新增的这种情况，其他情况下解析的结果都保持一致吗？

@CherishCai
Copy link
Contributor Author

能在PR中添加一下UT吗？ 以保证除了你新增的这种情况，其他情况下解析的结果都保持一致吗？

好的，晚点提交

CherishCai added a commit to CherishCai/nacos that referenced this issue Jun 8, 2021
@CherishCai
feat(alibaba#5888): add UT for NamingResourceParser and ConfigResourc…
fe532ef 
…eParser
KomachiSion pushed a commit that referenced this issue Jun 9, 2021
@CherishCai
Feat resource parser group (#5889)
c025dc2 
* feat(#5888): ResourceParser groupName change the splicing method.

* feat(#5888): add UT for NamingResourceParser and ConfigResourceParser
@KomachiSion KomachiSion added this to the 2.0.2 milestone Jun 9, 2021
@CherishCai CherishCai mentioned this issue Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TsingLiang TsingLiang

Labels
kind/refactor
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
3 participants
@TsingLiang @CherishCai @KomachiSion