The interval at which the heartbeat is sent in BeatReactor is not controlled by the server return value.

[darkness463]

最近在看Nacos源码，截止目前的master分支，在com.alibaba.nacos.client.naming.beat.BeatReactor类的实现中，默认启动时会以5秒一次的频率发送心跳，BeatProcessor会对dom2Beat中的每个值创建BeatTask发送心跳，在BeatTask中会接收服务端返回的clientBeatInterval字段并设置给BeatReactor类中的clientBeatInterval。关键代码如下：

    class BeatProcessor implements Runnable {

        @Override
        public void run() {
            try {
                for (Map.Entry<String, BeatInfo> entry : dom2Beat.entrySet()) {
                    BeatInfo beatInfo = entry.getValue();
                    if (beatInfo.isScheduled()) {
                        continue;
                    }
                    beatInfo.setScheduled(true);
                    executorService.schedule(new BeatTask(beatInfo), 0, TimeUnit.MILLISECONDS);
                }
            } catch (Exception e) {
                LogUtils.LOG.error("CLIENT-BEAT", "Exception while scheduling beat.", e);
            }
        }
    }

    class BeatTask implements Runnable {

        BeatInfo beatInfo;

        public BeatTask(BeatInfo beatInfo) {
            this.beatInfo = beatInfo;
        }

        @Override
        public void run() {
            long result = serverProxy.sendBeat(beatInfo);
            beatInfo.setScheduled(false);
            if (result > 0) {
                clientBeatInterval = result;
            }
        }
    }

我理解设计目的是根据服务端返回的心跳间隔来调整客户端发送心跳的频率，但在BeatReactor的构造函数中，BeatProcessor是用以下代码启动的：

executorService.scheduleAtFixedRate(new BeatProcessor(), 0, clientBeatInterval, TimeUnit.MILLISECONDS);

所以导致的结果是，不管服务端返回的clientBeatInterval值是多少，客户端都只会以5秒的间隔发送心跳，返回值对心跳任务没有任何影响。是bug还是我理解有问题？

[nacos-bot]

Hi @darkness463, we detect non-English characters in the issue. This comment is an auto translation from @nacos-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

The interval at which the heartbeat is sent in BeatReactor is not controlled by the server return value.

Recently, I am looking at the Nacos source. As of the current master branch, in the implementation of the com.alibaba.nacos.client.naming.beat.BeatReactor class, the heartbeat will be sent at a frequency of 5 seconds by default. BeatProcessor will Create a BeatTask for each value in dom2Beat to send a heartbeat. In BeatTask, it will receive the clientBeatInterval field returned by the server and set it to clientBeatInterval in the BeatReactor class. The key code is as follows:

    class BeatProcessor implements Runnable {

        @Override
        public void run() {
            try {
                for (Map.Entry<String, BeatInfo> entry : dom2Beat.entrySet()) {
                    BeatInfo beatInfo = entry.getValue();
                    if (beatInfo.isScheduled()) {
                        continue;
                    }
                    beatInfo.setScheduled(true);
                    executorService.schedule(new BeatTask(beatInfo), 0, TimeUnit.MILLISECONDS);
                }
            } catch (Exception e) {
                LogUtils.LOG.error("CLIENT-BEAT", "Exception while scheduling beat.", e);
            }
        }
    }

    class BeatTask implements Runnable {

        BeatInfo beatInfo;

        public BeatTask(BeatInfo beatInfo) {
            this.beatInfo = beatInfo;
        }

        @Override
        public void run() {
            long result = serverProxy.sendBeat(beatInfo);
            beatInfo.setScheduled(false);
            if (result > 0) {
                clientBeatInterval = result;
            }
        }
    }

I understand that the design goal is to adjust the frequency at which the client sends heartbeats based on the heartbeat interval returned by the server, but in the constructor of BeatReactor, BeatProcessor is started with the following code:

executorService.scheduleAtFixedRate(new BeatProcessor(), 0, clientBeatInterval, TimeUnit.MILLISECONDS);

So the result is that regardless of the value of the clientBeatInterval returned by the server, the client will only send heartbeats at 5 second intervals, and the return value has no effect on the heartbeat task. Is it a bug or do I understand that there is a problem?

[nkorange]

@darkness463
Can you create a PR to fix this?

[darkness463]

@i will solve it@

[nkorange]

@darkness463 Thank you very much, your commit has been accepted.