Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus接口不支持鉴权，新增对该接口的鉴权 #9710

Closed
realJackSun opened this issue Dec 15, 2022 · 2 comments · Fixed by #9912
Closed

Prometheus接口不支持鉴权，新增对该接口的鉴权 #9710

realJackSun opened this issue Dec 15, 2022 · 2 comments · Fixed by #9912
Assignees
@vividfish
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@realJackSun
Copy link
Collaborator

image
@vividfish
Copy link
Contributor

我试下 @ i will solve it @

@KomachiSion KomachiSion added the kind/discussion Category issues related to discussion label Dec 19, 2022
@KomachiSion
Copy link
Collaborator

这个接口是暴露给prometheus进行服务发现的， 那如果需要加鉴权需要看下prometheus来查询的时候是否能够扩展带上身份信息。

vividfish added a commit to vividfish/nacos that referenced this issue Feb 7, 2023
@vividfish
[ISSUE alibaba#9710]prometheus-sd support basic auth.
75f672a
vividfish added a commit to vividfish/nacos that referenced this issue Feb 7, 2023
@vividfish
[ISSUE alibaba#9710]prometheus-sd support basic auth.
56cb58f
KomachiSion pushed a commit that referenced this issue Feb 8, 2023
@vividfish
[ISSUE #9710]prometheus-sd support basic auth. (#9912)
4e08d61 
* [ISSUE #9710]prometheus-sd support basic auth.

* [ISSUE #9710]prometheus-sd support basic auth.
@KomachiSion KomachiSion mentioned this issue Feb 8, 2023
Merged
5 tasks
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. and removed kind/discussion Category issues related to discussion labels Feb 8, 2023
@KomachiSion KomachiSion mentioned this issue Mar 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vividfish vividfish

Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #9710]prometheus-sd support basic auth. vividfish/nacos
3 participants
@vividfish @KomachiSion @realJackSun