Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ipv6 Not perfect Support / IPv6 支持不完善 #978

Closed
tao1991123 opened this issue Mar 30, 2019 · 3 comments · Fixed by #3773
Closed

[BUG] Ipv6 Not perfect Support / IPv6 支持不完善 #978

tao1991123 opened this issue Mar 30, 2019 · 3 comments · Fixed by #3773
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement. priority/normal normal , may need sometime to complete.

Comments

@tao1991123
Copy link

tao1991123 commented Mar 30, 2019

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

  • Use API /nacos/v1/ns/instance to register a service with a valid ipv6, It respond 400 Bad Request.
  • 使用PUT /nacos/v1/ns/instance 注册服务的时候, 传入了一个合法的ipv6地址.得到400的响应.
    在 GET /nacos/v1/ns/instance又能够获取到这个实例。

此外发现一个拼写错误 malfomed ip config: fe80::3c:7d01:f92a:8dd0:7001:unknown_1.0_true_false_DEFAULT malformed 畸形的, 少了一个r

Describe what you expected to happen

When register a service, IPv6 should be allowed

Fully Support IPv6:

  • PUT /nacos/v1/ns/instance with a valid ipv6 , response success
  • GET /nacos/v1/ns/instance should return ipv6 instance

完全支持IPv6:

  • PUT /nacos/v1/ns/instance 传入IPv6不报错可以正常注册
  • GET /nacos/v1/ns/instance 同时也能被获取到

更正拼写错误 / Fix the spell mistake

How to reproduce it (as minimally and precisely as possible)

  1. download https://github.com/nacos-group/nacos-docker/
  2. docker-compose -f example/standalone-derby.yaml up
  3. curl -X PUT 'http://127.0.0.1:8848/nacos/v1/ns/instance?clusterName=DEFAULT&enable=true&healthy=true&ip=fe80::3c:7d01:f92a:8dd0&metadata={}&port=7001&serviceName=nodejs.test.domain&tenant=default&weight=1'
  4. Response 400

Tell us your environment

Docker latest image

Anything else we need to know?

@nacos-bot nacos-bot added the kind/bug Category issues or prs related to bug. label Mar 30, 2019
@nacos-bot
Copy link
Collaborator

nacos-bot commented Mar 30, 2019

Hi @tao1991123, we detect non-English characters in the issue. This comment is an auto translation from @nacos-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

[BUG] Ipv6 Not Fully Support / IPv6 support is not perfect

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

Use API /nacos/v1/ns/instance to register a service with a valid ipv6, It respond 400 Bad Request.
When registering a service with PUT /nacos/v1/ns/instance, a valid ipv6 address is passed in. Get a response of 400.
This instance can be obtained again in GET /nacos/v1/ns/instance.

Describe what you expected to happen

When register a service, IPv6 should be allowed

Full support for IPv6:

  • PUT /nacos/v1/ns/instance Incoming IPv6 without error, can be registered normally
  • GET /nacos/v1/ns/instance can also be obtained

How to reproduce it (as minimally and precisely as possible)

  1. download https://github.com/nacos-group/nacos-docker/
  2. docker-compose -f example/standalone-derby.yaml up
  3. curl -X PUT 'http://127.0.0.1:8848/nacos/v1/ns/instance?clusterName=DEFAULT&enable=true&healthy=true&ip=fe80::3c:7d01:f92a:8dd0&metadata={}&port=7001&serviceName=nodejs.test.domain&tenant=default&weight=1'
  4. Response 400

Tell us your environment

Docker latest image

Anything else we need to know?

@nacos-bot nacos-bot changed the title [BUG] Ipv6 Not Fully Support / IPv6支持不完善 [BUG] Ipv6 Not Fully Support / IPv6 support is not perfect Mar 30, 2019
@tao1991123 tao1991123 changed the title [BUG] Ipv6 Not Fully Support / IPv6 support is not perfect [BUG] Ipv6 Not perfect Support / IPv6 支持不完善 Mar 30, 2019
@nkorange nkorange added priority/normal normal , may need sometime to complete. kind/enhancement labels Apr 1, 2019
@nkorange
Copy link
Collaborator

nkorange commented Apr 1, 2019

@tao1991123 Will support in future, welcome to contribute to this feature.

@nkorange nkorange added contribution welcome and removed kind/bug Category issues or prs related to bug. labels Apr 1, 2019
@nkorange nkorange added kind/enhancement Category issues or prs related to enhancement. and removed kind/enhancement labels Apr 22, 2019
@neatlife
Copy link
Contributor

neatlife commented Apr 30, 2019

@i will solve it@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement. priority/normal normal , may need sometime to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants