Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFORM] Nacos cluster management implementation rejected in Apache SkyWalking #981

Closed
wu-sheng opened this issue Apr 1, 2019 · 7 comments
Assignees
Milestone

Comments

@wu-sheng
Copy link
Contributor

wu-sheng commented Apr 1, 2019

Hi Nacos team

I am sorry for both of these

  1. Reject a PR for supporting nacos as an optional cluster management implementation. [Rejected by License Issue]add cluster nacos support apache/skywalking#2422 by @litian33
  2. Submit an issue to discuss this.

I need your confirmation about, does Nacos really depend on GPL license libs? I have tried to leave messages in gitter, but no response, also twitter has no update for nearly 2 years.

So I think this is maybe the only choice. Because the Chinese channel, like wechat, is not an option for Apache project, which can't be archived in public.

If the GPL dependency exist, then my suggestion in PR is right, this implementation needs to be hosted out of Apache repo. Otherwise, you maybe could clear the dependency.

Anyway, this is just an informing action and discussion. If you think this is unnecessary, feel free to close this.

Sorry again.

@nkorange
Copy link
Collaborator

nkorange commented Apr 1, 2019

I just read the discussion under apache/incubator-skywalking#2422. nacos-client does depends on some libraries with GPL licenses. How can we solve this problem so Apache Skywalking can accept this PR?

@wu-sheng
Copy link
Contributor Author

wu-sheng commented Apr 1, 2019

I just read the discussion under apache/skywalking#2422. nacos-client does depends on some libraries with GPL licenses. How can we solve this problem so Apache Skywalking can accept this PR?

I think Apache requires all dependencies are in Catalog A. In some cases, Catalog B is acceptable in binary, which is nacos client case(SkyWalking doesn't host Nacos and Nacos dependencies) source codes).

@wu-sheng
Copy link
Contributor Author

wu-sheng commented Apr 1, 2019

This means all GPL/LGPL dependencies must be removed permanently.

@xuechaos
Copy link
Member

xuechaos commented Apr 1, 2019

@wu-sheng Thank you, We have scanned the GPL of Nacos before, but have relaxed the restrictions on LGPL 2.1. Apache has requirements for LGPL, and we will fix this problem as soon as possible, and Thanks again.

@wu-sheng
Copy link
Contributor Author

Status update, Nacos cluster management has landed in Apache SkyWalking. apache/skywalking#2640

@nkorange
Copy link
Collaborator

Status update, Nacos cluster management has landed in Apache SkyWalking. apache/skywalking#2640

It's a very good news. Thanks a ton for your work and the contribution as well.

@wu-sheng
Copy link
Contributor Author

@IanCao made that happens, I am just a reviewer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants