Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapperProxy.java #10487

Merged
merged 5 commits into from
May 17, 2023
Merged

Update MapperProxy.java #10487

merged 5 commits into from
May 17, 2023

Conversation

scwlkq
Copy link
Contributor

@scwlkq scwlkq commented May 15, 2023

fix:代理类打印日志错误

#10486

fix:代理类打印日志错误
@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

fix:代理类打印日志错误
KomachiSion
KomachiSion previously approved these changes May 16, 2023
@KomachiSion
Copy link
Collaborator

It seems ci can't pass, please fix them.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #10487 (4b760ee) into develop (6cde13b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10487      +/-   ##
=============================================
- Coverage      53.30%   53.29%   -0.01%     
- Complexity      5446     5447       +1     
=============================================
  Files            895      895              
  Lines          28436    28440       +4     
  Branches        3119     3120       +1     
=============================================
  Hits           15157    15157              
- Misses         11945    11950       +5     
+ Partials        1334     1333       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cde13b...4b760ee. Read the comment docs.

@scwlkq scwlkq requested a review from KomachiSion May 16, 2023 10:25
@@ -35,20 +36,20 @@
* @author hyx
**/
public class MapperProxy implements InvocationHandler {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent changed, please use nacos code style to reformat code.

@scwlkq
Copy link
Contributor Author

scwlkq commented May 16, 2023

Sorry, due to the first submission, I did not carefully read the nacos pr specification, which wasted the review time

@scwlkq scwlkq requested a review from KomachiSion May 16, 2023 14:06
@KomachiSion
Copy link
Collaborator

Sorry, due to the first submission, I did not carefully read the nacos pr specification, which wasted the review time

No problem, PR keeping enhance and fix will be merged.

@KomachiSion KomachiSion merged commit ee30e35 into alibaba:develop May 17, 2023
5 checks passed
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. plugin labels May 17, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone May 17, 2023
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* Update MapperProxy.java

fix:代理类打印日志错误

* Update MapperProxy.java

fix:代理类打印日志错误

* 规范格式

* Update MapperProxy.java

reformat code

* Update MapperProxy.java

reformat code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants