New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #10787] Fixed the memory performance issue caused by the creat… #10937
Conversation
…e creation of a large number of sessions. Signed-off-by: wangyongtao <wangyongtao@yiche.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动会不会影响客户端登录时的user name获取?
l
我自己浏览器和nacos-client测了下,没发现啥问题,内存利用又和1.4.2一样丝滑了。 |
我印象中这个改动好像是为了解决有slb/nginx之类的负载均衡的时候, 登录失效的问题,改动之后应该对于这个场景又会有问题, 有什么好的版本解决内存问题的时候同时解决这个场景问题吗? |
这个我还得试验下,但是应该以优先解决内存问题为主。 |
先跑下ci, 没问题就合进去,近期发新版本。 帮忙看下2.x是否有相同的问题,提个PR修复一下。 |
跑失败了嘛,就改了两行代码 |
check style没有过 |
我处理下 |
Signed-off-by: wangyongtao <wangyongtao@yiche.com>
处理了 |
…ion of a large number of sessions.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.