Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failover triggered mistakenly #11536

Merged
merged 5 commits into from Mar 7, 2024

Conversation

nkorange
Copy link
Collaborator

@nkorange nkorange commented Dec 21, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix failover switch triggered mistakenly and optimise metrics

Brief changelog

  1. only mute notification for the services in failover service list.
  2. optimise the using of micrometer.

Verifying this change

  1. turn on failover and put svc.1 to the failover list.
  2. subscribe svc.1 and svc.2.
  3. trigger instance list change to svc.1 and svc.2.
  4. observe that svc.1 has no notification, while svc.2 has.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023

CLA assistant check
All committers have signed the CLA.

@nkorange nkorange changed the title Fix failover switch triggered mistakenly and optimise metrics failover triggered mistakenly Dec 21, 2023
@nkorange nkorange closed this Mar 5, 2024
@nkorange nkorange reopened this Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.76%. Comparing base (b7c3905) to head (ebbb5fc).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11536      +/-   ##
=============================================
- Coverage      67.80%   67.76%   -0.05%     
+ Complexity      8892     8891       -1     
=============================================
  Files           1237     1237              
  Lines          40443    40446       +3     
  Branches        4286     4288       +2     
=============================================
- Hits           27424    27409      -15     
- Misses         11046    11063      +17     
- Partials        1973     1974       +1     
Files Coverage Δ
...a/nacos/client/naming/cache/ServiceInfoHolder.java 92.03% <0.00%> (ø)
...a/nacos/client/naming/backups/FailoverReactor.java 73.40% <7.69%> (-17.81%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c3905...ebbb5fc. Read the comment docs.

@KomachiSion KomachiSion merged commit 2f2fc1b into alibaba:develop Mar 7, 2024
13 checks passed
@KomachiSion KomachiSion added the area/Client Related to Nacos Client SDK label Mar 7, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Mar 7, 2024
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.3.2 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants