Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IISSUE#11793 Fix logback.xml Incorrect configuration #11794

Merged
merged 1 commit into from Mar 7, 2024

Conversation

heihei180
Copy link
Contributor

@heihei180 heihei180 commented Mar 4, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fixs #11793
modify the log file path. use relative paths instead of absolute paths.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@heihei180 heihei180 changed the title modify the log file path. IISSUE#11793 logback.xml Incorrect configuration Mar 4, 2024
@heihei180 heihei180 changed the title IISSUE#11793 logback.xml Incorrect configuration IISSUE#11793 Fix logback.xml Incorrect configuration Mar 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (92dda94) to head (43a2bc2).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11794      +/-   ##
=============================================
+ Coverage      67.81%   67.87%   +0.06%     
- Complexity      8893     8901       +8     
=============================================
  Files           1237     1237              
  Lines          40443    40443              
  Branches        4286     4286              
=============================================
+ Hits           27425    27450      +25     
+ Misses         11046    11025      -21     
+ Partials        1972     1968       -4     

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92dda94...43a2bc2. Read the comment docs.

@KomachiSion KomachiSion merged commit 15fbf92 into alibaba:develop Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants