Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify nacos app labels collector and log fix. #11867

Merged
merged 5 commits into from Mar 22, 2024

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.29114% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 68.30%. Comparing base (9fd6ff6) to head (b19329e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11867      +/-   ##
=============================================
+ Coverage      67.95%   68.30%   +0.35%     
  Complexity      8977     8977              
=============================================
  Files           1245     1239       -6     
  Lines          40657    40560      -97     
  Branches        4308     4311       +3     
=============================================
+ Hits           27629    27706      +77     
+ Misses         11041    10865     -176     
- Partials        1987     1989       +2     
Files Coverage Δ
...n/java/com/alibaba/nacos/api/common/Constants.java 58.33% <ø> (ø)
...libaba/nacos/client/env/NacosClientProperties.java 100.00% <ø> (ø)
...a/nacos/common/remote/client/RpcClientFactory.java 92.00% <ø> (+22.30%) ⬆️
...server/service/dump/disk/ConfigRawDiskService.java 78.26% <ø> (+14.09%) ⬆️
...er/service/dump/disk/ConfigRocksDbDiskService.java 83.22% <ø> (+7.61%) ⬆️
...mon/labels/impl/DefaultLabelsCollectorManager.java 93.75% <89.47%> (+27.08%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 75.89% <53.84%> (-0.68%) ⬇️
...alibaba/nacos/client/env/SearchableProperties.java 91.86% <14.28%> (-6.88%) ⬇️
...cos/common/labels/impl/DefaultLabelsCollector.java 64.28% <62.50%> (-35.72%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd6ff6...b19329e. Read the comment docs.

@KomachiSion KomachiSion merged commit 6dc0a21 into alibaba:develop Mar 22, 2024
7 checks passed
@shiyiyue1102 shiyiyue1102 deleted the develop-taggray20240321 branch March 22, 2024 09:42
@KomachiSion KomachiSion added this to the 2.3.2 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants