Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#12235]Fix the incorrect logging format in the ResponseExceptionHand… #12236

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

HMYDK
Copy link
Contributor

@HMYDK HMYDK commented Jun 16, 2024

…ler of the naming module.

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12235
Fix the incorrect logging format in the ResponseExceptionHandler of the naming module.

@HMYDK HMYDK changed the title [#12235]Fix the incorrect logging format in the ResponseExceptionHand… [ISSUE#12235]Fix the incorrect logging format in the ResponseExceptionHand… Jun 16, 2024
return ResponseEntity.status(e.getErrCode()).body(e.getMessage());
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the indents.

Copy link
Contributor Author

@HMYDK HMYDK Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我使用项目中的nacos-code-style-for-idea.xml重新格式化了代码。

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (d68b904) to head (0e20a56).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12236      +/-   ##
=============================================
+ Coverage      68.76%   68.77%   +0.01%     
- Complexity      9227     9230       +3     
=============================================
  Files           1264     1264              
  Lines          41183    41187       +4     
  Branches        4361     4363       +2     
=============================================
+ Hits           28318    28328      +10     
+ Misses         10828    10821       -7     
- Partials        2037     2038       +1     
Files Coverage Δ
...cos/naming/exception/ResponseExceptionHandler.java 25.00% <20.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d68b904...0e20a56. Read the comment docs.

@KomachiSion KomachiSion merged commit 27da090 into alibaba:develop Jun 24, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 24, 2024
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the ResponseExceptionHandler of the naming module, the wrong logging format was used.
3 participants