Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SecurityProxy.accessToken threadsafe in single writer multi reader #4778

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Jan 22, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

  • add volatile keywork, make SecurityProxy.accessToken threadsafe in single writer multi reader.
  • adjust initRefreshTask, make SecurityProxy.login not running concurrently

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In login method, there is judgement for token refresh windows.

And both of them is in init method, no multiple reader I think.

@shalk
Copy link
Contributor Author

shalk commented Jan 25, 2021

In login method, there is judgement for token refresh windows.

And both of them is in init method, no multiple reader I think.

refresh windows can not lock the login(Server) at first time, because initDely is zero, and securityProxy.login(getServerList()) will run in different thread.

the problem is two writers work on share var without volatile or lock.

If we change the order , securityProxy.login(getServerList()) will running in order like single writer. ref ServerHttpAgent#L278

May be this is not big deal, but it is good convention for concurrent program.

@KomachiSion KomachiSion added this to the 1.4.2 milestone Jan 26, 2021
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. kind/refactor labels Jan 26, 2021
@KomachiSion KomachiSion merged commit d4d245f into alibaba:develop Jan 26, 2021
@shalk shalk deleted the develop-fix-login branch March 6, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. kind/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants