Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5351] Remove blocked thread for Protocol metadata #5354

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Apr 13, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

After depending Jraft, protocol metadata can be subscribe for each key. One key and value will build an ValueItem to save data and observer. But the old implementation only four notify thread and ValueItem will block notify thread if no observer, which will cause some observer may not be called if there are more than four ValueItems without observer.

So I change the logic. Remove the notify thread and notify observer by main thread.

For non-block thread, removing the wait logic for observer. And when observer added, call update immediately to let observer can be notify at first.

After this PR, the observer of naming persistent server will be called, and change the Down to Up as expected.

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Apr 13, 2021
@KomachiSion KomachiSion added this to the 1.4.2 milestone Apr 13, 2021
@KeRan213539 KeRan213539 merged commit e689c1a into alibaba:develop Apr 13, 2021
@KomachiSion KomachiSion deleted the develop-issue#5351 branch May 18, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos1.4.1 selected the leader successfully, but the peer status of "Down" is not changed to "UP"
2 participants