Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5437]: change dump-task taskKey #5440

Merged
merged 2 commits into from
Apr 22, 2021
Merged

[ISSUE #5437]: change dump-task taskKey #5440

merged 2 commits into from
Apr 22, 2021

Conversation

CherishCai
Copy link
Contributor

fix #5437

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

KomachiSion
KomachiSion requested changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CI problem, please fix it first

shiyiyue1102
shiyiyue1102 reviewed Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@shiyiyue1102 shiyiyue1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check pass.

shiyiyue1102
shiyiyue1102 previously approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@shiyiyue1102 shiyiyue1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check ok

@KomachiSion KomachiSion merged commit e0fe828 into alibaba:develop Apr 22, 2021
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Config labels Apr 22, 2021
@KomachiSion KomachiSion added this to the 1.4.2 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

@shiyiyue1102 shiyiyue1102 shiyiyue1102 left review comments

Assignees
No one assigned
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

Nacos beta to full release, client access configuration inconsistency
4 participants
@CherishCai @CLAassistant @shiyiyue1102 @KomachiSion