HistoryController add @Secured #5885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from alibaba:develop
CherishCai
force-pushed
the
develop-feat-history-secured
branch
from
43000ba
to
b36c24c
Compare
KomachiSion
requested changes
May 31, 2021
| @@ -74,7 +78,11 @@ | |||
| * @return history config info | |||
| */ | |||
| @GetMapping | |||
| public ConfigHistoryInfo getConfigHistoryInfo(@RequestParam("nid") Long nid) { | |||
| @Secured(action = ActionTypes.READ, parser = ConfigResourceParser.class) | |||
| public ConfigHistoryInfo getConfigHistoryInfo(@RequestParam("dataId") String dataId, // for @Secured | |||
There was a problem hiding this comment.
Please do not change the paramters
There was a problem hiding this comment.
persistService find detailConfigHistory add params dataId, group, tenant
| @@ -86,7 +94,11 @@ public ConfigHistoryInfo getConfigHistoryInfo(@RequestParam("nid") Long nid) { | |||
| * @since 1.4.0 | |||
| */ | |||
| @GetMapping(value = "/previous") | |||
| public ConfigHistoryInfo getPreviousConfigHistoryInfo(@RequestParam("id") Long id) { | |||
| @Secured(action = ActionTypes.READ, parser = ConfigResourceParser.class) | |||
| public ConfigHistoryInfo getPreviousConfigHistoryInfo(@RequestParam("dataId") String dataId, // for @Secured | |||
There was a problem hiding this comment.
Please do not change the paramters
There was a problem hiding this comment.
persistService find detailConfigHistory add params dataId, group, tenant
…s dataId, group, tenant
|
关闭 PR，期望社区商议更优实现 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat #5884