[develop] add request type field at the head of task data, exchange parse order between Log and GetRequest #7871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrlw
force-pushed
the
patch-applyOperation
branch
from
a91255c
to
80d69d3
Compare
zrlw
force-pushed
the
patch-applyOperation
branch
from
80d69d3
to
755d569
Compare
zrlw
changed the title
|
我同意两次try catch非常不优雅，但是目前这样运行起来无问题， 关于issue中提出的关于先Write的异议，目前没有WriteRequest只设置了2个字段，我查看至少都有设置3个以上，比如data，operation和group。 因此在找到合理的替代方式之前建议保持原样。 |
KomachiSion
requested changes
Mar 3, 2022
| return result; | ||
| if (bytes[0] == REQUEST_TYPE_FIELD_TAG) { | ||
| if (bytes[1] == REQUEST_TYPE_READ) { | ||
| result = ReadRequest.parseFrom(bytes); |
There was a problem hiding this comment.
bytes中添加了2个标示位， parse之前应该移除掉这两个标示位，才能正确解析吧？
There was a problem hiding this comment.
不用删除，只是解析的结果多了个unknown fields，field的名称为编号7，grpc服务端和客户端可以通过unknown fields配置自己特有的字段，目的就是为了相互兼容老版本
兼容的，利用的是unknown fields机制 |
|
有搭建集群进行一下测试吗？ |
1.x一直在用集群压测试，2.0只测了单元功能。 |
KomachiSion
approved these changes
Mar 10, 2022
KomachiSion
added
area/Nacos Core
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
see #7757