Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #8611, Close old datasource connection. #9212

Merged
merged 1 commit into from Sep 26, 2022

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixes #8611.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Sep 26, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9212 (c8fa957) into develop (9a474a0) will decrease coverage by 0.18%.
The diff coverage is 18.13%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9212      +/-   ##
=============================================
- Coverage      43.72%   43.54%   -0.19%     
+ Complexity      4805     4802       -3     
=============================================
  Files            912      912              
  Lines          32769    32924     +155     
  Branches        3789     3816      +27     
=============================================
+ Hits           14329    14337       +8     
- Misses         17039    17179     +140     
- Partials        1401     1408       +7     
Impacted Files Coverage Δ
...gin/auth/impl/controller/PermissionController.java 0.00% <0.00%> (ø)
...os/plugin/auth/impl/controller/RoleController.java 0.00% <0.00%> (ø)
...os/plugin/auth/impl/controller/UserController.java 21.53% <0.00%> (-0.34%) ⬇️
...sistence/EmbeddedPermissionPersistServiceImpl.java 43.75% <0.00%> (-43.75%) ⬇️
...sistence/ExternalPermissionPersistServiceImpl.java 37.70% <0.00%> (-28.01%) ⬇️
...n/auth/impl/users/NacosUserDetailsServiceImpl.java 0.00% <0.00%> (ø)
...pl/persistence/ExternalRolePersistServiceImpl.java 45.78% <22.58%> (-15.63%) ⬇️
...pl/persistence/ExternalUserPersistServiceImpl.java 42.66% <24.13%> (-15.34%) ⬇️
...pl/persistence/EmbeddedRolePersistServiceImpl.java 60.31% <25.80%> (-31.79%) ⬇️
...pl/persistence/EmbeddedUserPersistServiceImpl.java 61.11% <28.57%> (-35.67%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f135a...c8fa957. Read the comment docs.

@KomachiSion KomachiSion merged commit 2d84c0a into alibaba:develop Sep 26, 2022
@KomachiSion KomachiSion deleted the develop-issue#8611 branch September 26, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议ExternalStoragePersistServiceImpl类实现对数据源的销毁destory操作
3 participants