Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9020, prefix CUSTOM_SEARCH_LOCATIONS with 'optional:' #9617

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

dc-orz
Copy link

@dc-orz dc-orz commented Nov 21, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #9020

Brief changelog

prefix CUSTOM_SEARCH_LOCATIONS with 'optional:' in startup.sh/startup.cmd

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2022

CLA assistant check
All committers have signed the CLA.

@KomachiSion KomachiSion added this to the 1.4.5 milestone Nov 22, 2022
@KomachiSion KomachiSion merged commit 3d6dff4 into alibaba:v1.x-develop Nov 22, 2022
@dc-orz dc-orz deleted the v1.x-develop branch November 22, 2022 15:18
@dc-orz dc-orz restored the v1.x-develop branch November 22, 2022 15:18
@dc-orz dc-orz deleted the v1.x-develop branch November 22, 2022 15:18
@dc-orz dc-orz restored the v1.x-develop branch November 22, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants