Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: loop execInspect to get result for cri manager's exec method #1086

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/S labels Apr 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #1086 into master will decrease coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   16.53%   16.15%   -0.38%     
==========================================
  Files         161      161              
  Lines        8908     8857      -51     
==========================================
- Hits         1473     1431      -42     
+ Misses       7331     7321      -10     
- Partials      104      105       +1
Impacted Files Coverage Δ
daemon/mgr/cri_stream.go 0% <0%> (ø) ⬆️
daemon/mgr/cri.go 0% <0%> (ø) ⬆️
client/client.go 12.5% <0%> (-22.99%) ⬇️
pkg/kernel/kernel.go 72.72% <0%> (-7.28%) ⬇️
pkg/utils/utils.go 82.17% <0%> (+0.1%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 10, 2018
@allencloud allencloud merged commit 42cd312 into AliyunContainerService:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants