Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor mistakes in pouch_with_runV.md docs #1189

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

xiechengsheng
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix minor mistakes in pouch_with_runV.md docs. The runV build path should be $Home/go/src/github.com/hyperhq

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@xiechengsheng Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @xiechengsheng
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

ping @xiechengsheng

CI fails according integration system.
Please refer to the CI failure Details button to corresponding test, and update your PR to pass CI.

If this is flaky test, welcome to track this with profiling an issue.

build url: https://travis-ci.org/alibaba/pouch/builds/370077033
build duration: 220s

@allencloud
Copy link
Collaborator

allencloud commented Apr 23, 2018

CI fails according to network issues of git repo golint, see below:

RUN go get -u github.com/golang/lint/golint
 ---> Running in 15dec7a3a67a
# cd .; git clone https://go.googlesource.com/lint /go/src/golang.org/x/lint
Cloning into '/go/src/golang.org/x/lint'...
fatal: remote error: Git repository not found
package golang.org/x/lint: exit status 128
The command '/bin/sh -c go get -u github.com/golang/lint/golint' returned a non-zero code: 1
make: *** [cri-test] Error 1

Just record this.

Actually I have already considering to use a base image which includes all essential tools, rather than dynamically building one with dockerfile.

@HusterWan
Copy link
Contributor

@xiechengsheng Enjoy hacking !!!

Can you rebase your pull request to just one commit, we will be very appreciate your work ?

@allencloud
Copy link
Collaborator

The golint issue is fixed in pr #1193.
I think we could merge this doc related pull request.
LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 24, 2018
@allencloud allencloud merged commit 14e005f into AliyunContainerService:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/runv LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants