Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add code coverage icon on README #1893

Merged

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

Add code coverage icon on README so that everything could get the code coverage when reading the readme page.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #1893 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   58.68%   58.66%   -0.03%     
==========================================
  Files         200      200              
  Lines       15565    15565              
==========================================
- Hits         9135     9131       -4     
- Misses       5143     5146       +3     
- Partials     1287     1288       +1
Flag Coverage Δ
#criv1alpha1test 33.29% <ø> (+0.08%) ⬆️
#criv1alpha2test 33.74% <ø> (-0.05%) ⬇️
#integrationtest 37.86% <ø> (-0.04%) ⬇️
#unittest 13.43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/stream/httpstream/spdy/upgrade.go 54.28% <0%> (-5.72%) ⬇️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@sunyuan3
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 26, 2018
@sunyuan3 sunyuan3 merged commit b469e1e into AliyunContainerService:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants