Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: http_utils_test: add cases for func BoolValue #2565

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

sanmaopep
Copy link
Contributor

Ⅰ. Describe what this PR did

add unit test case for func BoolValue

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #2565 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
+ Coverage   69.13%   69.19%   +0.06%     
==========================================
  Files         278      278              
  Lines       18607    18607              
==========================================
+ Hits        12864    12876      +12     
+ Misses       4268     4261       -7     
+ Partials     1475     1470       -5
Flag Coverage Δ
#criv1alpha1test 31.29% <ø> (+0.11%) ⬆️
#criv1alpha2test 35.59% <ø> (+0.03%) ⬆️
#integrationtest 40.65% <ø> (-0.05%) ⬇️
#nodee2etest 32.59% <ø> (+0.02%) ⬆️
#unittest 26.79% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 69.21% <0%> (-0.26%) ⬇️
cri/v1alpha2/cri_wrapper.go 64.4% <0%> (ø) ⬆️
daemon/mgr/container.go 58.91% <0%> (+0.21%) ⬆️
cri/v1alpha1/cri.go 60.92% <0%> (+0.66%) ⬆️
ctrd/container.go 58.81% <0%> (+0.79%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @sanmaopep
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2018

CLA assistant check
All committers have signed the CLA.

pkg/httputils/http_utils_test.go Outdated Show resolved Hide resolved
pkg/httputils/http_utils_test.go Show resolved Hide resolved
pkg/httputils/http_utils_test.go Outdated Show resolved Hide resolved
@ZYecho
Copy link
Contributor

ZYecho commented Dec 17, 2018

@sanmaopep thanks for your contribution, just a little suggestions.

@sanmaopep
Copy link
Contributor Author

@ZYecho I will modify them and appreciate your suggestions for my first PR 😄

Signed-off-by: maoyiwei <jsmyw95@qq.com>
@ZYecho
Copy link
Contributor

ZYecho commented Dec 18, 2018

LGTM

@allencloud
Copy link
Collaborator

Thanks for your great work. @sanmaopep
Merging...

@allencloud allencloud merged commit c7f57ea into AliyunContainerService:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants