-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: http_utils_test: add cases for func BoolValue #2565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2565 +/- ##
==========================================
+ Coverage 69.13% 69.19% +0.06%
==========================================
Files 278 278
Lines 18607 18607
==========================================
+ Hits 12864 12876 +12
+ Misses 4268 4261 -7
+ Partials 1475 1470 -5
|
We found this is your first time to contribute to Pouch, @sanmaopep |
@sanmaopep thanks for your contribution, just a little suggestions. |
@ZYecho I will modify them and appreciate your suggestions for my first PR 😄 |
0f37062
to
fd3baa7
Compare
Signed-off-by: maoyiwei <jsmyw95@qq.com>
LGTM |
Thanks for your great work. @sanmaopep |
Ⅰ. Describe what this PR did
add unit test case for func BoolValue
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
go test
Ⅴ. Special notes for reviews