fix update spec annotation in runtime spec to support comma #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: allen.wang <allen.wq@alipay.com>
Codecov Report
@@ Coverage Diff @@
## master #2780 +/- ##
=========================================
+ Coverage 68.64% 69.3% +0.65%
=========================================
Files 277 277
Lines 17425 17425
=========================================
+ Hits 11961 12076 +115
+ Misses 4108 4021 -87
+ Partials 1356 1328 -28
|
allencloud
reviewed
Apr 2, 2019
| @@ -55,7 +55,7 @@ func (uc *UpdateCommand) addFlags() { | |||
| flagSet.StringSliceVarP(&uc.labels, "label", "l", nil, "Update labels for container") | |||
| flagSet.StringVar(&uc.restartPolicy, "restart", "", "Restart policy to apply when container exits") | |||
| flagSet.StringSliceVar(&uc.diskQuota, "disk-quota", nil, "Update disk quota for container(/=10g)") | |||
| flagSet.StringSliceVar(&uc.specAnnotation, "annotation", nil, "Update annotation for runtime spec") | |||
| flagSet.StringArrayVar(&uc.specAnnotation, "annotation", nil, "Update annotation for runtime spec") | |||
There was a problem hiding this comment.
Could you add more detailed description of specAnnotation in swagger:
SpecAnnotation:
description: "annotations send to runtime spec."
type: "object"
additionalProperties:
type: "string"
Actually, users can hardly understand the actual meaning of it. Can you add some example for it in swagger.yml? @wangforthinker
allencloud
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang allen.wq@alipay.com
Ⅰ. Describe what this PR did
fix cli update to support comma in annotation update.
Ⅱ. Does this pull request fix one issue?
none.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add cases.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews