Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup workDir will change the dir ownership on host #2831

Merged
merged 1 commit into from
May 10, 2019

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

When setting WorkingDir for a container, we should first decide where should create the directory.
If the WorkingDir is in a volume, we should create the dir in the volume.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@HusterWan HusterWan requested a review from rudyfly May 8, 2019 04:07
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #2831 into master will increase coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2831      +/-   ##
=========================================
+ Coverage   69.15%   69.2%   +0.05%     
=========================================
  Files         279     279              
  Lines       17607   17621      +14     
=========================================
+ Hits        12176   12195      +19     
+ Misses       4051    4047       -4     
+ Partials     1380    1379       -1
Flag Coverage Δ
#criv1alpha2_test 39.39% <57.89%> (+0.01%) ⬆️
#integration_test_0 36.37% <42.1%> (ø) ⬆️
#integration_test_1 35.23% <52.63%> (+0.04%) ⬆️
#integration_test_2 36.36% <57.89%> (-0.02%) ⬇️
#integration_test_3 35.3% <42.1%> (-0.02%) ⬇️
#node_e2e_test 35.08% <0%> (+0.05%) ⬆️
#unittest 28.65% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/container_storage.go 60.24% <100%> (ø) ⬆️
daemon/mgr/container_types.go 71.32% <78.57%> (+0.83%) ⬆️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
cri/ocicni/cni_manager.go 58.49% <0%> (-1.89%) ⬇️
cri/v1alpha2/cri.go 68.81% <0%> (-0.26%) ⬇️
ctrd/container.go 54.26% <0%> (+0.37%) ⬆️
daemon/mgr/container.go 60.18% <0%> (+0.63%) ⬆️
ctrd/supervisord/daemon.go 50.67% <0%> (+1.35%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️
cri/ocicni/netns.go 60.81% <0%> (+2.7%) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented May 10, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 10, 2019
@rudyfly rudyfly merged commit 84a1817 into AliyunContainerService:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants