Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix error when input 'inspect -f {{.Id}}' #2855

Merged

Conversation

KevinBetterQ
Copy link
Contributor

Ⅰ. Describe what this PR did

can not use pouch inspect -f "{{.Id}}" to get container id, so fix it.

Ⅱ. Does this pull request fix one issue?

fixes #2841

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

added

Ⅳ. Describe how to verify it

pouch inspect -f "{{.Id}}"

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #2855 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
- Coverage   69.09%   69.07%   -0.03%     
==========================================
  Files         285      285              
  Lines       17844    17844              
==========================================
- Hits        12330    12326       -4     
- Misses       4114     4115       +1     
- Partials     1400     1403       +3
Flag Coverage Δ
#criv1alpha2_test 39.02% <ø> (+0.01%) ⬆️
#integration_test_0 36.53% <ø> (-0.04%) ⬇️
#integration_test_1 35.76% <ø> (ø) ⬆️
#integration_test_2 36.52% <ø> (+0.05%) ⬆️
#integration_test_3 35.47% <ø> (+0.02%) ⬆️
#node_e2e_test 34.7% <ø> (-0.08%) ⬇️
#unittest 28.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 59.25% <0%> (-1.86%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 76.76% <0%> (-1.02%) ⬇️
daemon/mgr/container.go 59.72% <0%> (-0.63%) ⬇️
ctrd/container.go 53.53% <0%> (-0.39%) ⬇️
cri/v1alpha2/cri.go 69.06% <0%> (ø) ⬆️
ctrd/supervisord/daemon.go 50.67% <0%> (+1.35%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️
cri/ocicni/netns.go 60.81% <0%> (+2.7%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels May 19, 2019
@allencloud
Copy link
Collaborator

Please also add this feature into integration test, not only unit test. @KevinBetterQ Thanks.

Signed-off-by: KevinBetterQ <1093850932@qq.com>
@ZYecho
Copy link
Contributor

ZYecho commented May 24, 2019

LGTM

@CodeJuan
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] can not use inspect -f "{{.Id}}" to get container id
5 participants