Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cri support update runtime config #2904

Conversation

zhuangqh
Copy link
Contributor

Ⅰ. Describe what this PR did

pouch write the runtime-config to a file

fill in the ip range field in podNetwork config each time.

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

pouch write the runtime-config to a file

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #2904 into master will increase coverage by 0.18%.
The diff coverage is 68.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
+ Coverage    68.7%   68.88%   +0.18%     
==========================================
  Files         291      291              
  Lines       18238    18304      +66     
==========================================
+ Hits        12530    12609      +79     
+ Misses       4244     4235       -9     
+ Partials     1464     1460       -4
Flag Coverage Δ
#criv1alpha2_test 38.36% <41.46%> (ø) ⬆️
#integration_test_0 36.1% <0%> (-0.11%) ⬇️
#integration_test_1 35.5% <0%> (-0.14%) ⬇️
#integration_test_2 36.13% <0%> (-0.03%) ⬇️
#integration_test_3 35.59% <0%> (-0.15%) ⬇️
#node_e2e_test 34.26% <65.85%> (+0.2%) ⬆️
#unittest 28.02% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha2/cri_utils.go 89.83% <100%> (+0.1%) ⬆️
cri/v1alpha2/cri.go 69.04% <42.85%> (+0.99%) ⬆️
cri/ocicni/cni_manager.go 61.32% <61.4%> (+0.2%) ⬆️
daemon/mgr/container.go 60.35% <0%> (+0.41%) ⬆️
daemon/mgr/container_utils.go 77.77% <0%> (+1.01%) ⬆️
ctrd/supervisord/daemon.go 50.67% <0%> (+1.35%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
... and 2 more

@rudyfly
Copy link
Collaborator

rudyfly commented Jun 21, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 21, 2019
@rudyfly rudyfly merged commit d4ba492 into AliyunContainerService:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants