Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: bump critest and k8s e2e test to 1.14 #2910

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #2910 into master will decrease coverage by 0.7%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   68.85%   68.15%   -0.71%     
==========================================
  Files         291      291              
  Lines       18259    18262       +3     
==========================================
- Hits        12573    12447     -126     
- Misses       4231     4362     +131     
+ Partials     1455     1453       -2
Flag Coverage Δ
#criv1alpha2_test 34.82% <54.54%> (-3.53%) ⬇️
#integration_test_0 36.25% <0%> (-0.01%) ⬇️
#integration_test_1 35.62% <0%> (-0.05%) ⬇️
#integration_test_2 36.17% <0%> (-0.03%) ⬇️
#integration_test_3 35.73% <0%> (-0.01%) ⬇️
#node_e2e_test 34.13% <81.81%> (-0.08%) ⬇️
#unittest 28.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/logger/crilog/log.go 81.94% <81.81%> (+2.23%) ⬆️
cri/v1alpha2/container_unpause.go 0% <0%> (-81.82%) ⬇️
cri/v1alpha2/container_pause.go 0% <0%> (-81.82%) ⬇️
pkg/exec/command.go 23.8% <0%> (-7.15%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
storage/quota/prjquota.go 15.43% <0%> (-5.37%) ⬇️
cri/v1alpha2/cri.go 64.26% <0%> (-4.8%) ⬇️
daemon/mgr/container_storage.go 54.9% <0%> (-4.51%) ⬇️
storage/quota/quota.go 6.51% <0%> (-4.19%) ⬇️
daemon/mgr/container_state.go 96.66% <0%> (-3.34%) ⬇️
... and 5 more

@zhuangqh
Copy link
Contributor Author

zhuangqh commented Jun 17, 2019

critest fail

• Failure in Spec Teardown (AfterEach) [9.071 seconds]
[k8s.io] Container
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/framework.go:72
  runtime should support basic operations on container
  /home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/container.go:68
    runtime should support execSync with timeout [Conformance] [AfterEach]
    /home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/container.go:132
    Unexpected error:
        <*status.statusError | 0xc00021dec0>: {
            Code: 2,
            Message: "failed to start exec for container \"54c49357beed217cc148f4e1b6188e9cd0a4ad1f48819a85bbe29d1ee2a6a40f\": context deadline exceeded: unknown",
            Details: nil,
        }
        rpc error: code = Unknown desc = failed to start exec for container "54c49357beed217cc148f4e1b6188e9cd0a4ad1f48819a85bbe29d1ee2a6a40f": context deadline exceeded: unknown
    occurred
    /home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/container.go:145

@zhuangqh zhuangqh force-pushed the upgrade-k8s-1.14 branch 3 times, most recently from cf6694b to 9ff871e Compare June 20, 2019 13:51
@pouchrobot pouchrobot added size/S and removed size/XS labels Jun 20, 2019
temporary skip critest: 'runtime should support execSync with timeout'

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants