Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make more events available to user #2933

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jun 26, 2019

Signed-off-by: zhangyue zy675793960@yeah.net

Ⅰ. Describe what this PR did

according docker’s event, add more events to help debug.

Ⅱ. Does this pull request fix one issue?

fix #2932

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need.

Ⅳ. Describe how to verify it

None.

Ⅴ. Special notes for reviews

after this pr was merged, the events below are supported.

Container

  • commit
  • create
  • destroy
  • exec_create
  • exec_start
  • pause
  • rename
  • resize
  • restart
  • start
  • stop
  • top
  • unpause
  • update
  • extract-to-dir
  • archive-path
  • oom
  • exec_die
  • die

Image

  • delete
  • load
  • pull
  • push
  • save
  • tag
  • untag

Volume

  • create
  • destroy
  • attach
  • detach

Network

  • create
  • connect
  • destroy
  • disconnect

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #2933 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2933      +/-   ##
==========================================
- Coverage   68.18%   68.07%   -0.12%     
==========================================
  Files         291      291              
  Lines       18339    18354      +15     
==========================================
- Hits        12505    12495      -10     
- Misses       4376     4394      +18     
- Partials     1458     1465       +7
Flag Coverage Δ
#criv1alpha2_test 34.79% <16.66%> (-0.02%) ⬇️
#integration_test_0 36.02% <50%> (-0.01%) ⬇️
#integration_test_1 35.6% <83.33%> (+0.1%) ⬆️
#integration_test_2 35.96% <41.66%> (-0.02%) ⬇️
#integration_test_3 35.58% <66.66%> (+0.02%) ⬆️
#node_e2e_test 34.09% <16.66%> (-0.12%) ⬇️
#unittest 27.94% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/image.go 59.13% <ø> (+0.29%) ⬆️
daemon/mgr/volume.go 83% <100%> (+0.34%) ⬆️
daemon/mgr/container_commit.go 57.14% <100%> (+1.04%) ⬆️
daemon/mgr/container.go 59.43% <100%> (-0.71%) ⬇️
daemon/mgr/container_exec.go 80% <100%> (+0.32%) ⬆️
daemon/mgr/container_copy.go 57.98% <100%> (+0.5%) ⬆️
daemon/mgr/image_load.go 58.33% <100%> (+1.81%) ⬆️
daemon/mgr/image_save.go 55.55% <100%> (+5.55%) ⬆️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
ctrd/container.go 52% <0%> (-2.3%) ⬇️
... and 5 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Jun 26, 2019
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @ZYecho
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@ZYecho ZYecho changed the title fix: add more events fix: make more events available to user Jun 26, 2019
@ZYecho ZYecho added areas/cli and removed kind/bug This is bug report for project labels Jun 26, 2019
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Jun 26, 2019
@ZYecho ZYecho force-pushed the fix-event-type branch 2 times, most recently from 0112caa to 2ef0aea Compare June 29, 2019 14:12
Signed-off-by: zhangyue <zy675793960@yeah.net>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] make more events available
3 participants