Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #2939

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Update CONTRIBUTING.md #2939

merged 1 commit into from
Jul 2, 2019

Conversation

slievrly
Copy link
Contributor

@slievrly slievrly commented Jul 2, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request head (patch-1@f1a03b1). Click here to learn what that means.
The diff coverage is n/a.

@pouchrobot
Copy link
Collaborator

@slievrly Thanks for your contribution. 🍻
Please sign off in each of your commits.

@allencloud
Copy link
Collaborator

thanks, good catch. LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 2, 2019
@allencloud allencloud merged commit 2eca3db into AliyunContainerService:master Jul 2, 2019
@pouchrobot pouchrobot mentioned this pull request Jul 5, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Jul 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slievrly @pouchrobot @allencloud