feature: add exec timeout support #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
==========================================
- Coverage 68.25% 59.92% -8.34%
==========================================
Files 291 291
Lines 18347 18351 +4
==========================================
- Hits 12523 10997 -1526
- Misses 4366 5929 +1563
+ Partials 1458 1425 -33
|
ZYecho
commented
Jul 11, 2019
ZYecho
force-pushed
the
add-exec-timeout
branch
4 times, most recently
from
14fac8c
to
98da71a
Compare
ZYecho
commented
Jul 11, 2019
zhuangqh
reviewed
Jul 15, 2019
Signed-off-by: zhangyue <zy675793960@yeah.net>
Ace-Tang
pushed a commit
that referenced
this pull request
Aug 20, 2019
Signed-off-by: zhangyue <zy675793960@yeah.net> （cherry pick from #2946） Signed-off-by: huaihuan.zy <huaihuan.zy@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue zy675793960@yeah.net
Ⅰ. Describe what this PR did
if exec hang， we need a way to to clean up the resource.
use ctx to judge if timeout， if happen，try to kill with SIGKILL first， then try to kill with SIGTERM
Ⅱ. Does this pull request fix one issue?
fix #2916
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
wait for CI
Ⅳ. Describe how to verify it
wait for CI
Ⅴ. Special notes for reviews
None