Feature raxui #149
Merged
Feature raxui #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanyan
reviewed
Mar 3, 2017
packages/rax-calendar/package.json
Outdated
| "rax-text": "^0.2.2", | ||
| "rax-scrollview": "^0.2.2", | ||
| "rax-touchable": "^0.2.2", | ||
| "moment": "~2.13.0" |
yuanyan
reviewed
Mar 3, 2017
|
|
||
| import Day from './Day'; | ||
|
|
||
| import moment from 'moment/min/moment.min'; |
There was a problem hiding this comment.
依赖改为 import moment from 'moment';
yuanyan
reviewed
Mar 3, 2017
packages/rax-calendar/src/Day.js
Outdated
| @@ -0,0 +1,91 @@ | |||
| import {createElement, Component, PropTypes} from 'rax'; | |||
| import View from '@ali/rax-view'; | |||
yuanyan
reviewed
Mar 3, 2017
packages/rax-calendar/src/index.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| import Index from './Calendar'; | |||
| export default Index; | |||
yuanyan
reviewed
Mar 3, 2017
packages/rax-calendar/src/styles.js
Outdated
| width: DEVICE_WIDTH, | ||
| }, | ||
| monthHeading: { | ||
| padding: '10rem', |
There was a problem hiding this comment.
所有单位用 number 格式，比如：padding: '10rem' 改为 padding: 10
yuanyan
reviewed
Mar 3, 2017
| null | ||
| } | ||
| <Text style={timeStyle}> | ||
| {'' + displayFirstNum} |
There was a problem hiding this comment.
{'' + displayFirstNum} 可以简化为 {displayFirstNum}
There was a problem hiding this comment.
此处有一个本周发现的 weex 上渲染问题，数字类型 0 会重复渲染出一层 text 标签，我这边在定位
yuanyan
reviewed
Mar 3, 2017
packages/rax-countdown/src/index.js
Outdated
| formatFunc: PropTypes.func, | ||
| onTick: PropTypes.func, | ||
| onComplete: PropTypes.func, | ||
| tpl: PropTypes.string, // 倒计时展示模板 |
yuanyan
reviewed
Mar 3, 2017
packages/rax-gotop/src/index.js
Outdated
| let scroll; | ||
|
|
||
| if (!isWeex) { | ||
| var raf = window.requestAnimationFrame || window.webkitRequestAnimationFrame || function(c) { |
yuanyan
reviewed
Mar 3, 2017
packages/rax-gotop/src/index.js
Outdated
| bottom = props.bottom || 125; | ||
|
|
||
| if (isWeex) { | ||
| bottom += 'rem'; |
yuanyan
reviewed
Mar 3, 2017
packages/rax-gotop/src/index.js
Outdated
| }; | ||
|
|
||
| GoTop.defaultProps = { | ||
| name: '顶部', |
yuanyan
reviewed
Mar 3, 2017
packages/rax-gotop/src/index.js
Outdated
|
|
||
| GoTop.defaultProps = { | ||
| name: '顶部', | ||
| icon: 'https://gw.alicdn.com/tps/TB1UhIvLXXXXXaRXpXXXXXXXXXX-60-66.png', |
yuanyan
reviewed
Mar 3, 2017
packages/rax-grid/src/Col.js
Outdated
| @@ -0,0 +1,44 @@ | |||
| import {Component, createElement} from 'rax'; | |||
|
|
|||
| let defaultWidth = window.screen.width; | |||
There was a problem hiding this comment.
weex 下 window.screen.width 是屏幕真实像素宽度，是不是用错了这里
yuanyan
reviewed
Mar 3, 2017
packages/rax-grid/src/Col.js
Outdated
| <div {...this.props} style={style} /> | ||
| ); | ||
| } else { | ||
| // 如果仅有一个 child 则返回 child 标签 |
yuanyan
reviewed
Mar 3, 2017
packages/rax-grid/src/Col.js
Outdated
| const styles = { | ||
| initial: { | ||
| 'flex': 1, | ||
| 'width': '1%', |
yuanyan
reviewed
Mar 3, 2017
packages/rax-grid/src/MultiRow.js
Outdated
| colStyle: {}, | ||
| gridStyle: {}, | ||
| list: [], | ||
| temp: function() {} |
yuanyan
reviewed
Mar 3, 2017
packages/rax-tabheader/src/style.js
Outdated
| }, | ||
|
|
||
| iconContainer: { | ||
| // 'display':'flex', |
yuanyan
reviewed
Mar 3, 2017
| import Text from 'rax-text'; | ||
| import Image from 'rax-image'; | ||
|
|
||
| class Icon extends Component { |
There was a problem hiding this comment.
rax-icon 的实现有些问题，每次都需要重复传fontFamily与source，导致使用起来变扭
yuanyan
reviewed
Mar 6, 2017
packages/rax-grid/src/Grid.js
Outdated
| }; | ||
|
|
||
| return ( | ||
| <div {...this.props} style={style} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.