Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration module for Gin web framework #49

Closed
louyuting opened this issue Feb 17, 2020 · 0 comments · Fixed by #82
Closed

Add integration module for Gin web framework #49

louyuting opened this issue Feb 17, 2020 · 0 comments · Fixed by #82
Labels
area/integrations Issue related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or PRs related to feature request

Comments

@louyuting
Copy link
Collaborator

louyuting commented Feb 17, 2020 •
edited by sczyh30

Issue Description

Type: feature request

Describe what feature you want

Add integration module for Gin web framework. Discussions are needed.
@louyuting louyuting added kind/feature Category issues or PRs related to feature request area/integrations Issue related to integrations with open-source components and removed area/integrations Issue related to integrations with open-source components labels Feb 17, 2020
@sczyh30 sczyh30 changed the title Adapt gin framework for Sentinel Add integration module for Gin web framework Feb 18, 2020
@sczyh30 sczyh30 added area/integrations Issue related to integrations with open-source components good first issue Good for newcomers labels Feb 18, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Mar 9, 2020
@gorexlv
fix alibaba#49; add unit tests for gin
4b7b55a
@sczyh30 sczyh30 linked a pull request Mar 10, 2020 that will close this issue
fix #49; implement gin adapter #82
Merged
@louyuting louyuting added this to the 1.0.0 milestone Mar 14, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Mar 14, 2020
@gorexlv
fix alibaba#49; modify resource name separator
b2b60c5
@sczyh30 sczyh30 removed this from the 1.0.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integrations Issue related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or PRs related to feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #49; implement gin adapter gorexlv/sentinel-golang
2 participants
@louyuting @sczyh30