Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish the method LoadRules() in rule_manager.go #71

Closed
wuxuer opened this issue Feb 28, 2020 · 1 comment · Fixed by #72
Closed

polish the method LoadRules() in rule_manager.go #71

wuxuer opened this issue Feb 28, 2020 · 1 comment · Fixed by #72
Assignees
@wuxuer
Labels
kind/enhancement Category issues or PRs related to enhancement

Comments

@wuxuer
Copy link
Contributor

wuxuer commented Feb 28, 2020

Issue Description

Type: feature request

The implementation of LoadRules() in rule_manager.go might be not elegant, and the channel ruleChan seems to have no obvious meaning.

Describe what feature you want

Call onRuleUpdate() to load rules in LoadRules().

Additional context

Add any other context or screenshots about the feature request here.
@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label Feb 28, 2020
@wuxuer
Copy link
Contributor Author

wuxuer commented Feb 28, 2020

@louyuting @sczyh30
I will resolve the issue.

wuxuer added a commit to wuxuer/sentinel-golang that referenced this issue Feb 28, 2020
@wuxuer
polish the method LoadRules() in rule_manager.go (alibaba#71)
4ef7f78 
Remove the channel ruleChan which seems to have no obvious meaning.
LoadRules() call onRuleUpdate() to load system rules.
Add ClearRules() to clear all the previous rules.

Signed-off-by: xu wu <wuxu1103@163.com>
@sczyh30 sczyh30 linked a pull request Feb 28, 2020 that will close this issue
polish the method LoadRules() in system rule manager.go (#71) #72
Merged
@wenxuwan wenxuwan mentioned this issue Mar 3, 2020
Merged
wuxuer added a commit to wuxuer/sentinel-golang that referenced this issue Mar 12, 2020
@wuxuer
polish the method LoadRules() in rule_manager.go (alibaba#71)
3bf44c5 
Remove the channel ruleChan which seems to have no obvious meaning.
LoadRules() call onRuleUpdate() to load system rules.
Add ClearRules() to clear all the previous rules.

Signed-off-by: xu wu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/sentinel-golang that referenced this issue Mar 12, 2020
@wuxuer
polish the method LoadRules() in rule_manager.go (alibaba#71)
17a889a 
Remove the channel ruleChan which seems to have no obvious meaning.
LoadRules() call onRuleUpdate() to load system rules.
Add ClearRules() to clear all the previous rules.

Signed-off-by: xu wu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/sentinel-golang that referenced this issue Mar 17, 2020
@wuxuer
polish the method LoadRules() in rule_manager.go (alibaba#71)
5c61f35 
Remove the channel ruleChan which seems to have no obvious meaning.
LoadRules() call onRuleUpdate() to load system rules.
Add ClearRules() to clear all the previous rules.

Signed-off-by: xu wu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/sentinel-golang that referenced this issue Mar 17, 2020
@wuxuer
polish the method LoadRules() in rule_manager.go (alibaba#71)
4c6102f 
Remove the channel ruleChan which seems to have no obvious meaning.
LoadRules() call onRuleUpdate() to load system rules.
Add ClearRules() to clear all the previous rules.

Signed-off-by: xu wu <wuxu1103@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wuxuer wuxuer

Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

polish the method LoadRules() in system rule manager.go (#71) wuxuer/sentinel-golang
2 participants
@wuxuer @sczyh30