Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Datasource And PropertyListener #74

Closed
gorexlv opened this issue Feb 29, 2020 · 2 comments
Closed

Implement Datasource And PropertyListener #74

gorexlv opened this issue Feb 29, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@gorexlv
Copy link
Contributor

gorexlv commented Feb 29, 2020

Issue Description

  1. Implement DatasourceExtension and PropertyListener
  2. Multiple configuration formats are supported

Type: feature request

Describe what feature you want

if possible, avoid passing interface{} in Rule converter function, same or like this:

// *_rule_manager.go
func Convert(data interface{}) error {
        config := data.([]byte)
        // convert config to FlowRule/SystemRule
}

which is not elegant and maybe not friendly for multiple configuration format.

Additional context

Add any other context or screenshots about the feature request here.

@gorexlv gorexlv changed the title Avoid using interface in datasource converter Implement Datasource And PropertyListener Feb 29, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Feb 29, 2020
@gorexlv
Copy link
Contributor Author

gorexlv commented Feb 29, 2020

duplicated with #58

gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Feb 29, 2020
@louyuting
Copy link
Collaborator

duplicated with #58

Yes, I will close this issue.
We could discuss under #58
Discussion are welcomed.

@louyuting louyuting added the duplicate This issue or pull request already exists label Mar 1, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Mar 2, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants