Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pooling and time retrieval mechanism to optimize performance #155

Merged
merged 3 commits into from
Jun 4, 2020

Conversation

louyuting
Copy link
Collaborator

  1. pool EntryOption
  2. optimize EntryContext pool
  3. optimize time.Now

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

1. pool EntryOption
2. optimize EntryContext pool
3. optimize time.Now
@louyuting louyuting requested a review from sczyh30 June 3, 2020 15:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #155 into master will decrease coverage by 0.19%.
The diff coverage is 32.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   40.77%   40.57%   -0.20%     
==========================================
  Files          68       69       +1     
  Lines        3279     3322      +43     
==========================================
+ Hits         1337     1348      +11     
- Misses       1810     1839      +29     
- Partials      132      135       +3     
Impacted Files Coverage Δ
api/init.go 0.00% <0.00%> (ø)
core/base/context.go 20.51% <0.00%> (-1.11%) ⬇️
core/config/config.go 24.46% <0.00%> (-0.54%) ⬇️
util/time_ticker.go 22.22% <22.22%> (ø)
util/time.go 81.81% <33.33%> (-18.19%) ⬇️
api/api.go 32.43% <35.29%> (+0.28%) ⬆️
core/base/slot_chain.go 92.40% <100.00%> (+0.62%) ⬆️
core/config/entity.go 75.00% <100.00%> (+0.64%) ⬆️
util/auto_recover.go 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b892a...2c26ed1. Read the comment docs.

@louyuting louyuting added area/performance Issues or PRs related to runtime performance kind/enhancement Category issues or PRs related to enhancement to-review PRs to review labels Jun 4, 2020
core/config/entity.go Outdated Show resolved Hide resolved
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 9967812 into alibaba:master Jun 4, 2020
@sczyh30
Copy link
Member

sczyh30 commented Jun 4, 2020

Nice work. Cheers!

@sczyh30 sczyh30 removed the to-review PRs to review label Jun 4, 2020
@sczyh30 sczyh30 added this to the 0.4.0 milestone Jun 4, 2020
@sczyh30 sczyh30 changed the title Optimize performance. Improve pooling and time retrieval mechanism to optimize performance Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Issues or PRs related to runtime performance kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants