Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefect the datasource helper #157

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Prefect the datasource helper #157

merged 2 commits into from
Jun 17, 2020

Conversation

louyuting
Copy link
Collaborator

Describe what this PR does / why we need it

Refine some code
Prefect the datasource helper

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #157 into master will increase coverage by 1.83%.
The diff coverage is 79.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   42.71%   44.55%   +1.83%     
==========================================
  Files          76       76              
  Lines        3994     4112     +118     
==========================================
+ Hits         1706     1832     +126     
+ Misses       2094     2081      -13     
- Partials      194      199       +5
Impacted Files Coverage Δ
core/flow/rule.go 0.00% <ø> (ø)
core/hotspot/cache/concurrent_lru.go 95.74% <ø> (ø)
core/hotspot/cache/lru.go 53.77% <ø> (ø)
core/hotspot/concurrency_stat_slot.go 0.00% <ø> (ø)
core/hotspot/slot.go 32.95% <ø> (ø)
core/hotspot/traffic_shaping.go 64.58% <ø> (ø)
core/system/rule.go 90.00% <ø> (ø)
ext/datasource/property.go 81.81% <ø> (ø)
core/hotspot/rule_manager.go 58.18% <50.00%> (ø)
ext/datasource/helper.go 74.41% <77.95%> (+0.22%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d6c0d...0405ec5. Read the comment docs.

@louyuting louyuting requested a review from sczyh30 June 5, 2020 14:39
@louyuting louyuting added area/data-source Issues or PRs related to data-source extension kind/enhancement Category issues or PRs related to enhancement to-review PRs to review labels Jun 5, 2020
sczyh30
sczyh30 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit eecd776 into alibaba:master Jun 17, 2020
@sczyh30
Copy link
Member

sczyh30 commented Jun 17, 2020

Nice work. Thanks!

@sczyh30 sczyh30 removed the to-review PRs to review label Jun 17, 2020
gorexlv pushed a commit to gorexlv/sentinel-golang that referenced this pull request Jun 18, 2020
@louyuting @gorexlv
Polish data-source helper for rules and rename package of freq_params…
63445e2 
…_traffic module (alibaba#157)

* package rename: freq_params_traffic -> hotspot
* Also polish code of rule managers
@sczyh30 sczyh30 added this to the 0.4.0 milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczyh30 sczyh30 sczyh30 approved these changes

Assignees
No one assigned
Labels
area/data-source Issues or PRs related to data-source extension kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louyuting @codecov-commenter @sczyh30