Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record max concurrency in MetricItem and metric logs #371

Merged
merged 10 commits into from Jan 8, 2021

Conversation

liqiangz
Copy link
Contributor

@liqiangz liqiangz commented Jan 4, 2021

Describe what this PR does / why we need it

Record max concurrency in MetricItem and metric logs

Does this pull request fix one issue?

Fixes #349

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 4, 2021

Codecov Report

Merging #371 (7c3ab9c) into master (c059530) will increase coverage by 0.31%.
The diff coverage is 52.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   50.20%   50.52%   +0.31%     
==========================================
  Files          70       70              
  Lines        4089     4190     +101     
==========================================
+ Hits         2053     2117      +64     
- Misses       1759     1783      +24     
- Partials      277      290      +13     
Impacted Files Coverage Δ
core/stat/base/bucket_leap_array.go 57.57% <41.17%> (-1.89%) ⬇️
core/stat/base/sliding_window_metric.go 61.53% <55.55%> (-0.87%) ⬇️
core/stat/base/metric_bucket.go 77.77% <100.00%> (+6.34%) ⬆️
core/flow/rule_manager.go 61.09% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c059530...7c3ab9c. Read the comment docs.

@louyuting louyuting self-requested a review January 4, 2021 16:07
@louyuting louyuting added the area/metrics Issue related to metrics and monitoring label Jan 4, 2021
@louyuting louyuting added this to the 1.1.0 milestone Jan 4, 2021
@louyuting louyuting added the to-review PRs to review label Jan 4, 2021
@louyuting louyuting self-assigned this Jan 4, 2021
@louyuting louyuting requested a review from sczyh30 January 4, 2021 16:10
core/base/constant.go Outdated Show resolved Hide resolved
core/stat/base_node.go Outdated Show resolved Hide resolved
core/stat/base/metric_bucket.go Show resolved Hide resolved
core/stat/base/metric_bucket.go Outdated Show resolved Hide resolved
luckyxiaoqiang
luckyxiaoqiang previously approved these changes Jan 8, 2021
Copy link
Collaborator

@luckyxiaoqiang luckyxiaoqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

binbin0325
binbin0325 previously approved these changes Jan 8, 2021
Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luckyxiaoqiang luckyxiaoqiang merged commit aafce3f into alibaba:master Jan 8, 2021
@sczyh30 sczyh30 removed the to-review PRs to review label Jan 8, 2021
@liqiangz liqiangz deleted the MetricItem branch January 8, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Issue related to metrics and monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record max concurrency in MetricItem and metric logs
6 participants