Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg/datasource):Add apollo support #444

Merged
merged 5 commits into from
Dec 11, 2021
Merged

Conversation

Casper-Mars
Copy link
Contributor

Describe what this PR does / why we need it

Add apollo support

Does this pull request fix one issue?

#443

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2021

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added area/data-source Issues or PRs related to data-source extension kind/feature Category issues or PRs related to feature request to-review PRs to review labels Nov 29, 2021
@sczyh30
Copy link
Member

sczyh30 commented Nov 30, 2021

Could you please resolve the CI failure?

@Casper-Mars
Copy link
Contributor Author

Could you please resolve the CI failure?

Of course. I will try my best.

@@ -0,0 +1,51 @@
module github.com/alibaba/sentinel-golang/pkg/datasource/apollo

go 1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.17 might be too new for some legacy users. How about keeping 1.13 (if possible?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

replace github.com/alibaba/sentinel-golang => ../../../

require (
github.com/alibaba/sentinel-golang v1.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0.3 is available here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 257d5b8 into alibaba:master Dec 11, 2021
@sczyh30
Copy link
Member

sczyh30 commented Dec 11, 2021

Nice work. Thanks for contributing!

@sczyh30 sczyh30 removed the to-review PRs to review label Dec 11, 2021
@sczyh30 sczyh30 linked an issue Dec 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Apollo data-source
3 participants