Fix app name in metric is unknown_go_service (#453) #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you please fix the CI failure? |
Initialize global metric variables
binbin0325
reviewed
Apr 22, 2022
| "circuit_breaker_state_changed_total", | ||
| "Circuit breaker total state change count", | ||
| []string{"resource", "from_state", "to_state"}) | ||
| once sync.Once |
There was a problem hiding this comment.
There's no need to use sync.Once
There was a problem hiding this comment.
Is it possible to consider putting it inside a separate instance of sentinel instead of a global instance?
删除 once 导致的，是否不应该删除呢？ |
嗯嗯，目前看还是使用once吧 |
|
这个提交是否还有问题呢，然后什么时候能合并嘞，目前在最新的 [v1.0.4] tag 下还是有这个问题的 |
|
加油，需要这个修复 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #453
Describe how you did it
Describe how to verify it
Special notes for reviews