feat: add adapter for hertz #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Skyenought
force-pushed
the
add-hertz
branch
2 times, most recently
from
c3bb9d8
to
66f0e91
Compare
sczyh30
added
to-review
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 53.17% 53.17%
=======================================
Files 91 91
Lines 5896 5896
=======================================
Hits 3135 3135
Misses 2414 2414
Partials 347 347 Continue to review full report at Codecov.
|
binbin0325
reviewed
Jul 28, 2022
pkg/adapters/hertz/.gitignore
Outdated
| @@ -0,0 +1,66 @@ | |||
| # JetBrains template | |||
There was a problem hiding this comment.
gitignore is not required, it is already available in the main project
|
Nice work. Thanks for contributing! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
cloudwego/hertz#138
Does this pull request fix one issue?
cloudwego/hertz#138
Describe how you did it
The implementation is based on hertz middlewares for http server and client.
They have been tested in
server_test.goandclient_test.goDescribe how to verify it
The implementation can be verified via
go test.Special notes for reviews