Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Sentinel starter support parameter flow control #115

Closed
fangjian0423 opened this issue Nov 21, 2018 · 2 comments
Closed

[Feature] Sentinel starter support parameter flow control #115

fangjian0423 opened this issue Nov 21, 2018 · 2 comments
Assignees
@fangjian0423
Labels
area/sentinel spring cloud alibaba sentinel kind/enhancement
Milestone
0.2.1

Comments

@fangjian0423
Copy link
Contributor

fangjian0423 commented Nov 21, 2018 •
edited

include 3 steps.

  1. adding sentinel-parameter-flow-control dependency in spring-cloud-alibaba-sentinel module.
  2. automatically convert ParamFlowRule in JsonConverter and XmlConverter of spring-cloud-alibaba-sentinel-datasource module.
  3. add ParamFlowRule in actuator endpoint
@fangjian0423 fangjian0423 self-assigned this Nov 21, 2018
@fangjian0423 fangjian0423 mentioned this issue Nov 21, 2018
Closed
@sczyh30
Copy link
Member

sczyh30 commented Nov 29, 2018

Related to alibaba/Sentinel#273, please also add support for parameter rules in actuator endpoint.

@sczyh30 sczyh30 mentioned this issue Nov 29, 2018
Closed
@fangjian0423 fangjian0423 added this to the 0.2.1 milestone Nov 29, 2018
fangjian0423 added a commit to fangjian0423/spring-cloud-alibaba that referenced this issue Dec 6, 2018
@fangjian0423
Polish alibaba#115
cd6f79b
@fangjian0423
Copy link
Contributor Author

This issue will be closed when Sentinel 1.4.0 release because @SentinelResource is not supported with ParamFlowRule before 1.4.0 release.

@fangjian0423 fangjian0423 mentioned this issue Dec 6, 2018
Merged
fangjian0423 added a commit to fangjian0423/spring-cloud-alibaba that referenced this issue Dec 14, 2018
@fangjian0423
Polish alibaba#115 check ParamFlowRule
20741db
@fangjian0423 fangjian0423 added the area/sentinel spring cloud alibaba sentinel label Mar 22, 2019
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
@fangjian0423
Polish alibaba#115
8daa3e4
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
@fangjian0423
Polish alibaba#115 check ParamFlowRule
27a9c90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangjian0423 fangjian0423

Labels
area/sentinel spring cloud alibaba sentinel kind/enhancement
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
3 participants
@fangjian0423 @sczyh30 @flystar32