Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nacos-config-examples #3010

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Conversation

ruansheng8
Copy link
Collaborator

Describe what this PR does / why we need it

  1. 移除nacos-config-2.4.x-example模块
  2. nacos-config-example 相关调整:
    a. 移除spring-cloud-starter-bootstrap依赖 , 默认不再使用bootstrap.yml方式配置
    b. 移除nacos config shared-configsextension-configs 2中配置写法 , 新版本使用spring.config.import方式引入配置

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to introduce the way of spring.config.import by referring to spring cloud config . BTW, you need to modify relevant docs in SCA.

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ruansheng8 Please create a same PR to branch of 2021.x.

@steverao steverao merged commit 0cdd2d7 into alibaba:2022.x Jan 5, 2023
@steverao steverao added the waiting for sync waiting for sync to other main branchs label Jan 18, 2023
This was referenced Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for sync waiting for sync to other main branchs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants